[frontend] add ee highlight #2998
Open
+70
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## issue/2838-chunk-2 #2998 +/- ##
=====================================================
Coverage 40.20% 40.20%
Complexity 2209 2209
=====================================================
Files 664 664
Lines 20577 20577
Branches 1408 1408
=====================================================
Hits 8272 8272
Misses 11854 11854
Partials 451 451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -84,6 +82,7 @@ const Executors = () => { | |||
| <ExecutorSelector | |||
| executor={executor} | |||
| setSelectedExecutor={setSelectedExecutor} | |||
| isEEExecutor={executor.executor_type == OPENBAS_TANIUM || executor.executor_type == OPENBAS_CROWDSTRIKE} | |||
There was a problem hiding this comment.
question (for the whole PR): shouldn't we add this as a more generic property somewhere ? Maybe we need to add a isEE propetry in all executors in addition to the executor_type ?
impolitepanda
approved these changes
Apr 18, 2025
MarineLeM
force-pushed
the
issue/2838-chunk-2
branch
from
fd2c559 to
8a955f4
Compare
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
Signed-off-by: Marine LM <[email protected]>
MarineLeM
force-pushed
the
issue/2838-chunk-3
branch
from
da03f92 to
e214c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
on install agents :
on endpoint page
Related issues
Further comments